Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hannah60rgb rev.2 PCB #10287

Merged
merged 10 commits into from
Oct 4, 2020
Merged

Add hannah60rgb rev.2 PCB #10287

merged 10 commits into from
Oct 4, 2020

Conversation

mechlovin
Copy link
Contributor

Description

Add hannah60rgb rev.2 PCB.
Thanks.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/mechlovin/hannah60rgb/hannah60rgb.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev1/config.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev1/config.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/config.h Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/mechlovin/hannah60rgb/rev2/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 21, 2020 02:04
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@drashna drashna merged commit 793de76 into qmk:master Oct 4, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Oct 7, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (178 commits)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  [Keymap] Added 333fred 5x6_5 keymap (qmk#10272)
  [Keyboard] Add hannah60rgb rev.2 PCB (qmk#10287)
  Adding VIA support to katana60 rev2 (qmk#10442)
  OLED driver fixes (qmk#10377)
  IS31FL3741 driver fixup (qmk#10519)
  add info.json for XD75 keyboard (qmk#10523)
  ...
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* add hannah60rgb_rev2

* add

* Update rev2.c

* fixed rgb matrix

* Update rev2.c

* update rules.mk

* update readme

* update

* Update config.h

* Update rules.mk
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
* add hannah60rgb_rev2

* add

* Update rev2.c

* fixed rgb matrix

* Update rev2.c

* update rules.mk

* update readme

* update

* Update config.h

* Update rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants